Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for module comments in Fable.AST #4028

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

ncave
Copy link
Collaborator

@ncave ncave commented Jan 29, 2025

  • Add support for module comments in Fable.AST

@ncave
Copy link
Collaborator Author

ncave commented Jan 29, 2025

@MangelMaxime I'm not sure what the release cadence for Fable.AST is, do we need to bump the Fable.AST version to 5.0-* as this is technically a change, even though it's an optional property. If we do, now would be the time to align it with the Fable major release version.

@ncave ncave requested review from MangelMaxime and removed request for MangelMaxime January 29, 2025 17:20
@ncave ncave changed the title [Rust] Add support for module comments Add support for module comments in Fable.AST Feb 4, 2025
@ncave ncave merged commit ffc6ee9 into fable-compiler:main Feb 5, 2025
19 checks passed
@MangelMaxime
Copy link
Member

In general, Fable.AST was released when the AST changed yes and this one being the first time we need a release since Fable 5.

It make sense to start releasing Fable.AST 5 alpha IHMO.

I will merge all the different pending PRs today or tomorrow and make a new Fable release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants